[
https://issues.apache.org/jira/browse/BEAM-4290?focusedWorklogId=107333&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-107333
]
ASF GitHub Bot logged work on BEAM-4290:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/May/18 19:19
Start Date: 30/May/18 19:19
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #5489:
[BEAM-4290] proto changes to support artifact_staging_id
URL: https://github.com/apache/beam/pull/5489#discussion_r191891215
##########
File path: model/job-management/src/main/proto/beam_artifact_api.proto
##########
@@ -102,13 +99,19 @@ message ArtifactChunk {
bytes data = 1;
}
+message PutArtifactMetadata {
+ // (Required) An identifier for artifact staging session.
+ string artifact_staging_id = 1;
Review comment:
Given the diversity of ArtifactStagingService, its really hard to capture
all the required metadata.
One thing which we are trying to do in the proto is not to enforce any
implementation details.
From proto perspective, artifact_staging_id/token is just a text string. It
can very well be just an id and the implementation of the service can look up
that id in another system or it can just be json so that implementation can
extract all the relevant information from the token without referring to
another system.
This gives the implementation flexibility to implement the service in the
way they want.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 107333)
Time Spent: 2h 40m (was: 2.5h)
> ArtifactStagingService that stages to a distributed filesystem
> --------------------------------------------------------------
>
> Key: BEAM-4290
> URL: https://issues.apache.org/jira/browse/BEAM-4290
> Project: Beam
> Issue Type: Sub-task
> Components: runner-core
> Reporter: Eugene Kirpichov
> Assignee: Ankur Goenka
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Using the job's staging directory from PipelineOptions.
> Physical layout on the distributed filesystem is TBD but it should allow for
> arbitrary filenames and ideally for eventually avoiding uploading artifacts
> that are already there.
> Handling credentials is TBD.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
