[
https://issues.apache.org/jira/browse/BEAM-4276?focusedWorklogId=107865&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-107865
]
ASF GitHub Bot logged work on BEAM-4276:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/May/18 20:10
Start Date: 31/May/18 20:10
Worklog Time Spent: 10m
Work Description: wcn3 commented on a change in pull request #5507:
[BEAM-4276] Add combiner lifting support to Go SDK
URL: https://github.com/apache/beam/pull/5507#discussion_r192220206
##########
File path: sdks/go/pkg/beam/core/runtime/exec/combine_test.go
##########
@@ -60,9 +170,30 @@ func TestCombine(t *testing.T) {
if err := p.Down(context.Background()); err != nil {
t.Fatalf("down failed: %v", err)
}
+}
- expected := makeKV(42, 21)
- if !equalList(out.Elements, expected) {
- t.Errorf("pardo(sumFn) = %v, want %v",
extractKeyedValues(out.Elements...), extractKeyedValues(expected...))
+func mergeFn(a, b int) int {
+ return a + b
+}
+
+type MyCombine struct{}
Review comment:
Wouldn't hurt to add a comment indicating that int is the input type and
int64 is the accumulator and output type. The test is an authoritative piece of
code demonstrating the contract. That comment will help people write their own
combiners more easily, I believe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 107865)
Time Spent: 4h (was: 3h 50m)
> Implement the portable lifted Combiner transforms in Go SDK
> -----------------------------------------------------------
>
> Key: BEAM-4276
> URL: https://issues.apache.org/jira/browse/BEAM-4276
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Robert Burke
> Priority: Major
> Time Spent: 4h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
