[
https://issues.apache.org/jira/browse/BEAM-4276?focusedWorklogId=107859&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-107859
]
ASF GitHub Bot logged work on BEAM-4276:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/May/18 20:10
Start Date: 31/May/18 20:10
Worklog Time Spent: 10m
Work Description: wcn3 commented on a change in pull request #5507:
[BEAM-4276] Add combiner lifting support to Go SDK
URL: https://github.com/apache/beam/pull/5507#discussion_r192210019
##########
File path: sdks/go/pkg/beam/core/runtime/exec/combine.go
##########
@@ -42,10 +42,12 @@ type Combine struct {
err errorx.GuardedError
}
+// ID returns the UnitID for this node.
Review comment:
Do we want to consider embedding a "base class" struct that provides these
trivial behaviors? It reduces needless-looking code and would additionally
improve the output of golint since these methods would have 1, not N,
implementations.
Not necessary to make this change for this PR, just wanted to consider it.
Can open a JIRA if we agree it's worthwhile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 107859)
Time Spent: 3h 20m (was: 3h 10m)
> Implement the portable lifted Combiner transforms in Go SDK
> -----------------------------------------------------------
>
> Key: BEAM-4276
> URL: https://issues.apache.org/jira/browse/BEAM-4276
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Robert Burke
> Priority: Major
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
