[
https://issues.apache.org/jira/browse/BEAM-4276?focusedWorklogId=107858&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-107858
]
ASF GitHub Bot logged work on BEAM-4276:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/May/18 20:10
Start Date: 31/May/18 20:10
Worklog Time Spent: 10m
Work Description: wcn3 commented on a change in pull request #5507:
[BEAM-4276] Add combiner lifting support to Go SDK
URL: https://github.com/apache/beam/pull/5507#discussion_r192221853
##########
File path: sdks/go/pkg/beam/core/runtime/graphx/translate.go
##########
@@ -148,10 +148,58 @@ func (m *marshaller) addScopeTree(s *ScopeTree) string {
Inputs: diff(in, out),
Outputs: diff(out, in),
}
+
+ m.updateIfCombineComposite(s, transform)
+
m.transforms[id] = transform
return id
}
+// updateIfCombineComposite examines the scope tree and sets the PTransform
Spec
+// to be a CombinePerKey with a CombinePayload if it's a liftable composite.
+// Beam Portability requires that composites
Review comment:
Unfinished comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 107858)
Time Spent: 3h 10m (was: 3h)
> Implement the portable lifted Combiner transforms in Go SDK
> -----------------------------------------------------------
>
> Key: BEAM-4276
> URL: https://issues.apache.org/jira/browse/BEAM-4276
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Robert Burke
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
