[
https://issues.apache.org/jira/browse/BEAM-3773?focusedWorklogId=110718&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-110718
]
ASF GitHub Bot logged work on BEAM-3773:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jun/18 19:05
Start Date: 11/Jun/18 19:05
Worklog Time Spent: 10m
Work Description: XuMingmin commented on a change in pull request #5592:
[BEAM-3773] [SQL] Add support for setting PipelineOptions
URL: https://github.com/apache/beam/pull/5592#discussion_r194512765
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamIOSourceRel.java
##########
@@ -29,11 +30,17 @@
/** BeamRelNode to replace a {@code TableScan} node. */
public class BeamIOSourceRel extends TableScan implements BeamRelNode {
- private BeamSqlTable sqlTable;
+ private final BeamSqlTable sqlTable;
+ private final Map<String, String> pipelineOptions;
Review comment:
I would suggest to have `pipelineOptions` on system/session level. Think
about that the query has multiple tables, for join, what if they have different
settings?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 110718)
Time Spent: 14h 10m (was: 14h)
> [SQL] Investigate JDBC interface for Beam SQL
> ---------------------------------------------
>
> Key: BEAM-3773
> URL: https://issues.apache.org/jira/browse/BEAM-3773
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Anton Kedin
> Assignee: Andrew Pilloud
> Priority: Major
> Time Spent: 14h 10m
> Remaining Estimate: 0h
>
> JDBC allows integration with a lot of third-party tools, e.g
> [Zeppelin|https://zeppelin.apache.org/docs/0.7.0/manual/interpreters.html],
> [sqlline|https://github.com/julianhyde/sqlline]. We should look into how
> feasible it is to implement a JDBC interface for Beam SQL
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
