[
https://issues.apache.org/jira/browse/BEAM-3773?focusedWorklogId=110739&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-110739
]
ASF GitHub Bot logged work on BEAM-3773:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jun/18 19:48
Start Date: 11/Jun/18 19:48
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #5592:
[BEAM-3773] [SQL] Add support for setting PipelineOptions
URL: https://github.com/apache/beam/pull/5592#discussion_r194525494
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamIOSourceRel.java
##########
@@ -29,11 +30,17 @@
/** BeamRelNode to replace a {@code TableScan} node. */
public class BeamIOSourceRel extends TableScan implements BeamRelNode {
- private BeamSqlTable sqlTable;
+ private final BeamSqlTable sqlTable;
+ private final Map<String, String> pipelineOptions;
Review comment:
What do you mean by having `pipelineOptions` on the system/session level?
These concepts aren't really different in Beam, there isn't a persistent system
that can be configured separately from the session.
You can have multiple different `pipelineOptions` for tables if you have
multiple schema. However that isn't supported and you'll find that the default
`getPipelineOptions` asserts that every table has the same `pipelineOptions`
map. As long as your tables are all on the same schema, they will have the same
`pipelineOptions`.
If your question is why they are plumbed through here, that is because we
don't have a single system level config that can be accessed from the
BeamEnumerableConverter in every possible environment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 110739)
Time Spent: 14h 50m (was: 14h 40m)
> [SQL] Investigate JDBC interface for Beam SQL
> ---------------------------------------------
>
> Key: BEAM-3773
> URL: https://issues.apache.org/jira/browse/BEAM-3773
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Anton Kedin
> Assignee: Andrew Pilloud
> Priority: Major
> Time Spent: 14h 50m
> Remaining Estimate: 0h
>
> JDBC allows integration with a lot of third-party tools, e.g
> [Zeppelin|https://zeppelin.apache.org/docs/0.7.0/manual/interpreters.html],
> [sqlline|https://github.com/julianhyde/sqlline]. We should look into how
> feasible it is to implement a JDBC interface for Beam SQL
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
