[
https://issues.apache.org/jira/browse/BEAM-3773?focusedWorklogId=110750&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-110750
]
ASF GitHub Bot logged work on BEAM-3773:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jun/18 20:00
Start Date: 11/Jun/18 20:00
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #5592:
[BEAM-3773] [SQL] Add support for setting PipelineOptions
URL: https://github.com/apache/beam/pull/5592#discussion_r194529061
##########
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/JdbcDriverTest.java
##########
@@ -93,21 +107,39 @@ public void testDriverManager_ddl() throws Exception {
@Test
public void testInternalConnect_boundedTable() throws Exception {
- ReadOnlyTableProvider tableProvider =
- new ReadOnlyTableProvider(
- "test",
- ImmutableMap.of(
- "test",
- MockedBoundedTable.of(
- Schema.FieldType.INT32, "id",
- Schema.FieldType.STRING, "name")
- .addRows(1, "first")));
- CalciteConnection connection = JdbcDriver.connect(tableProvider);
+ CalciteConnection connection = JdbcDriver.connect(BOUNDED_TABLE);
Statement statement = connection.createStatement();
ResultSet resultSet = statement.executeQuery("SELECT * FROM test");
assertTrue(resultSet.next());
assertEquals(1, resultSet.getInt("id"));
assertEquals("first", resultSet.getString("name"));
assertFalse(resultSet.next());
}
+
+ @Test
+ public void testInternalConnect_setDirectRunner() throws Exception {
+ CalciteConnection connection = JdbcDriver.connect(BOUNDED_TABLE);
+ Statement statement = connection.createStatement();
+ assertEquals(0, statement.executeUpdate("SET runner = direct"));
Review comment:
A packaging story is part of it. Other runners also require a full
integration test as well, they can't just spin up in memory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 110750)
Time Spent: 15h 10m (was: 15h)
> [SQL] Investigate JDBC interface for Beam SQL
> ---------------------------------------------
>
> Key: BEAM-3773
> URL: https://issues.apache.org/jira/browse/BEAM-3773
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Anton Kedin
> Assignee: Andrew Pilloud
> Priority: Major
> Time Spent: 15h 10m
> Remaining Estimate: 0h
>
> JDBC allows integration with a lot of third-party tools, e.g
> [Zeppelin|https://zeppelin.apache.org/docs/0.7.0/manual/interpreters.html],
> [sqlline|https://github.com/julianhyde/sqlline]. We should look into how
> feasible it is to implement a JDBC interface for Beam SQL
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
