[ https://issues.apache.org/jira/browse/BEAM-4481?focusedWorklogId=110919&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-110919 ]
ASF GitHub Bot logged work on BEAM-4481: ---------------------------------------- Author: ASF GitHub Bot Created on: 12/Jun/18 00:41 Start Date: 12/Jun/18 00:41 Worklog Time Spent: 10m Work Description: chamikaramj commented on a change in pull request #5594: [BEAM-4481, BEAM-4484] Start vendoring portability dependencies to not have dependency conflicts URL: https://github.com/apache/beam/pull/5594#discussion_r194586156 ########## File path: build_rules.gradle ########## @@ -1253,6 +1254,125 @@ ext.applyGrpcNature = { /*************************************************************************************************/ +ext.applyPortabilityNature = { + println "applyPortabilityNature with " + (it ? "$it" : "default configuration") + " for project $project.name" + applyJavaNature(enableFindbugs: false, enableErrorProne: false, shadowClosure: { + // guava uses the com.google.common and com.google.thirdparty package namespaces + relocate "com.google.common", "org.apache.beam.vendor.guava.v20.com.google.common" + relocate "com.google.thirdparty", "org.apache.beam.vendor.guava.v20.com.google.thirdparty" + + relocate "com.google.protobuf", "org.apache.beam.vendor.protobuf.v3.com.google.protobuf" Review comment: Is there a way to error out if a jar contains a package that is not relocated here ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 110919) Time Spent: 3h 40m (was: 3.5h) > Remove duplicate dependency declarations from runners/direct-java > ----------------------------------------------------------------- > > Key: BEAM-4481 > URL: https://issues.apache.org/jira/browse/BEAM-4481 > Project: Beam > Issue Type: Bug > Components: runner-direct > Reporter: Luke Cwik > Assignee: Luke Cwik > Priority: Major > Time Spent: 3h 40m > Remaining Estimate: 0h > > beam-model-pipeline and others are duplicated in the dependency list -- This message was sent by Atlassian JIRA (v7.6.3#76005)