[ 
https://issues.apache.org/jira/browse/BEAM-4481?focusedWorklogId=111233&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111233
 ]

ASF GitHub Bot logged work on BEAM-4481:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Jun/18 19:24
            Start Date: 12/Jun/18 19:24
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on a change in pull request #5594: 
[BEAM-4481, BEAM-4484] Start vendoring portability dependencies to not have 
dependency conflicts
URL: https://github.com/apache/beam/pull/5594#discussion_r194860000
 
 

 ##########
 File path: build_rules.gradle
 ##########
 @@ -1253,6 +1254,125 @@ ext.applyGrpcNature = {
 
 
/*************************************************************************************************/
 
+ext.applyPortabilityNature = {
+  println "applyPortabilityNature with " + (it ? "$it" : "default 
configuration") + " for project $project.name"
+  applyJavaNature(enableFindbugs: false, enableErrorProne: false, 
shadowClosure: {
+    // guava uses the com.google.common and com.google.thirdparty package 
namespaces
+    relocate "com.google.common", 
"org.apache.beam.vendor.guava.v20.com.google.common"
+    relocate "com.google.thirdparty", 
"org.apache.beam.vendor.guava.v20.com.google.thirdparty"
+
+    relocate "com.google.protobuf", 
"org.apache.beam.vendor.protobuf.v3.com.google.protobuf"
 
 Review comment:
   That is already being done by the 
`validateShadedJarDoesntLeakNonOrgApacheBeamClasses` task.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 111233)
    Time Spent: 4h 20m  (was: 4h 10m)

> Remove duplicate dependency declarations from runners/direct-java
> -----------------------------------------------------------------
>
>                 Key: BEAM-4481
>                 URL: https://issues.apache.org/jira/browse/BEAM-4481
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-direct
>            Reporter: Luke Cwik
>            Assignee: Luke Cwik
>            Priority: Major
>          Time Spent: 4h 20m
>  Remaining Estimate: 0h
>
> beam-model-pipeline and others are duplicated in the dependency list



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to