ASF GitHub Bot logged work on BEAM-4481:

                Author: ASF GitHub Bot
            Created on: 12/Jun/18 19:23
            Start Date: 12/Jun/18 19:23
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on a change in pull request #5594: 
[BEAM-4481, BEAM-4484] Start vendoring portability dependencies to not have 
dependency conflicts
URL: https://github.com/apache/beam/pull/5594#discussion_r194859792

 File path: build_rules.gradle
 @@ -1253,6 +1254,125 @@ ext.applyGrpcNature = {
+ext.applyPortabilityNature = {
+  println "applyPortabilityNature with " + (it ? "$it" : "default 
configuration") + " for project $project.name"
+  applyJavaNature(enableFindbugs: false, enableErrorProne: false, 
shadowClosure: {
 Review comment:
   Eventually all projects will not do any shading and instead use normal 
dependencies (no more `shadow`, `shadowTest`). The only reason why I place this 
into a function right now is that I want to repeat this same logic across 
`model/pipeline`, `model/job-management`, `model/fn-execution`.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 111232)
    Time Spent: 4h 10m  (was: 4h)

> Remove duplicate dependency declarations from runners/direct-java
> -----------------------------------------------------------------
>                 Key: BEAM-4481
>                 URL: https://issues.apache.org/jira/browse/BEAM-4481
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-direct
>            Reporter: Luke Cwik
>            Assignee: Luke Cwik
>            Priority: Major
>          Time Spent: 4h 10m
>  Remaining Estimate: 0h
> beam-model-pipeline and others are duplicated in the dependency list

This message was sent by Atlassian JIRA

Reply via email to