[
https://issues.apache.org/jira/browse/BEAM-4007?focusedWorklogId=111437&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111437
]
ASF GitHub Bot logged work on BEAM-4007:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jun/18 08:23
Start Date: 13/Jun/18 08:23
Worklog Time Spent: 10m
Work Description: RobbeSneyders commented on a change in pull request
#5337: [BEAM-4007] Futurize typehints subpackage
URL: https://github.com/apache/beam/pull/5337#discussion_r194993891
##########
File path: sdks/python/apache_beam/typehints/typehints_test.py
##########
@@ -1034,8 +1040,14 @@ class DecoratorHelpers(TypeHintTestCase):
def test_hint_helper(self):
self.assertTrue(is_consistent_with(Any, int))
self.assertTrue(is_consistent_with(int, Any))
- self.assertTrue(is_consistent_with(str, object))
- self.assertFalse(is_consistent_with(object, str))
+ # object builtin is shadowed by object imported from future.builtins on
Review comment:
This is indeed evaluated differently.
I never was a fan of this workaround, but pushed it mostly to get feedback.
Looking back at it, I actually think we should not use `object` from
`future.builtins` in test modules, because we want to test for 'native' code.
We already decided not to use other `future.builtins` types in test modules
(mostly focused on `str` and `bytes`) because of the same reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 111437)
Time Spent: 1h (was: 50m)
> Futurize and fix python 2 compatibility for typehints subpackage
> ----------------------------------------------------------------
>
> Key: BEAM-4007
> URL: https://issues.apache.org/jira/browse/BEAM-4007
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Robbe
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
