[ https://issues.apache.org/jira/browse/BEAM-4007?focusedWorklogId=111439&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111439 ]
ASF GitHub Bot logged work on BEAM-4007: ---------------------------------------- Author: ASF GitHub Bot Created on: 13/Jun/18 08:25 Start Date: 13/Jun/18 08:25 Worklog Time Spent: 10m Work Description: RobbeSneyders commented on a change in pull request #5337: [BEAM-4007] Futurize typehints subpackage URL: https://github.com/apache/beam/pull/5337#discussion_r194992572 ########## File path: sdks/python/apache_beam/typehints/typehints.py ########## @@ -411,17 +416,23 @@ def __eq__(self, other): def __repr__(self): return 'Any' + def __hash__(self): + return hash(id(self)) + def type_check(self, instance): pass class TypeVariable(AnyTypeConstraint): + def __init__(self, name): + self.name = name + def __eq__(self, other): return type(self) == type(other) and self.name == other.name - def __init__(self, name): - self.name = name + def __hash__(self): Review comment: This is again the same issue as mentioned above. I actually think it might make more sense to change `__eq__` to be instance specific. If I specify `K = beam.typehints.TypeVariable('K')` in two separate places in my code base, I might not want them match. However, this might break some existing pipelines. I therefore tried to use the equivalent of the Python 2 code. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 111439) Time Spent: 1h 20m (was: 1h 10m) > Futurize and fix python 2 compatibility for typehints subpackage > ---------------------------------------------------------------- > > Key: BEAM-4007 > URL: https://issues.apache.org/jira/browse/BEAM-4007 > Project: Beam > Issue Type: Sub-task > Components: sdk-py-core > Reporter: Robbe > Assignee: Robbe > Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)