[
https://issues.apache.org/jira/browse/BEAM-4007?focusedWorklogId=111800&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111800
]
ASF GitHub Bot logged work on BEAM-4007:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jun/18 07:14
Start Date: 14/Jun/18 07:14
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #5337:
[BEAM-4007] Futurize typehints subpackage
URL: https://github.com/apache/beam/pull/5337#discussion_r195321747
##########
File path: sdks/python/apache_beam/typehints/typehints_test.py
##########
@@ -1034,8 +1040,14 @@ class DecoratorHelpers(TypeHintTestCase):
def test_hint_helper(self):
self.assertTrue(is_consistent_with(Any, int))
self.assertTrue(is_consistent_with(int, Any))
- self.assertTrue(is_consistent_with(str, object))
- self.assertFalse(is_consistent_with(object, str))
+ # object builtin is shadowed by object imported from future.builtins on
Review comment:
+1 for not importing the object from `future.builtins` in `typehints.py` .
Another option could be to to normalize `builtins.object` to native object here:
https://github.com/RobbeSneyders/beam/blob/4fc7965ba67fd22a7a7c4a3935ec295aca2811be/sdks/python/apache_beam/typehints/typehints.py#L1082.
But this feels brittle and it seems that importing object here is not that
critical.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 111800)
Time Spent: 1h 50m (was: 1h 40m)
> Futurize and fix python 2 compatibility for typehints subpackage
> ----------------------------------------------------------------
>
> Key: BEAM-4007
> URL: https://issues.apache.org/jira/browse/BEAM-4007
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Robbe
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
