[
https://issues.apache.org/jira/browse/BEAM-4000?focusedWorklogId=119048&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-119048
]
ASF GitHub Bot logged work on BEAM-4000:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jul/18 11:18
Start Date: 04/Jul/18 11:18
Worklog Time Spent: 10m
Work Description: RobbeSneyders commented on a change in pull request
#5715: [BEAM-4000] Futurize io subpackage
URL: https://github.com/apache/beam/pull/5715#discussion_r200094907
##########
File path: sdks/python/apache_beam/io/filebasedsource.py
##########
@@ -49,6 +48,13 @@
__all__ = ['FileBasedSource']
+try:
+ unicode # pylint: disable=unicode-builtin
Review comment:
The try/except was indeed used to prevent problems with typechecking when
using `builtins` from the future package.
However, I tested this again, and it seems that there are no such problems
using the `past.builtins`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 119048)
Time Spent: 3.5h (was: 3h 20m)
> Futurize and fix python 2 compatibility for io subpackage
> ---------------------------------------------------------
>
> Key: BEAM-4000
> URL: https://issues.apache.org/jira/browse/BEAM-4000
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
