[
https://issues.apache.org/jira/browse/BEAM-4000?focusedWorklogId=118980&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-118980
]
ASF GitHub Bot logged work on BEAM-4000:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jul/18 07:34
Start Date: 04/Jul/18 07:34
Worklog Time Spent: 10m
Work Description: Fematich commented on a change in pull request #5715:
[BEAM-4000] Futurize io subpackage
URL: https://github.com/apache/beam/pull/5715#discussion_r200032184
##########
File path: sdks/python/apache_beam/io/filebasedsource.py
##########
@@ -49,6 +48,13 @@
__all__ = ['FileBasedSource']
+try:
+ unicode # pylint: disable=unicode-builtin
Review comment:
I used the try/except method to be consistent with the methodology
implemented in #5053 and outlined in [the
doc](https://docs.google.com/document/d/1xDG0MWVlDKDPu_IW9gtMvxi2S9I0GB0VDTkPhjXT0nE/edit#heading=h.ir03vqq4rotn)
by @RobbeSneyders. I believe there where some issues in the coder package for
the typechecks using `past.utils`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 118980)
Time Spent: 2.5h (was: 2h 20m)
> Futurize and fix python 2 compatibility for io subpackage
> ---------------------------------------------------------
>
> Key: BEAM-4000
> URL: https://issues.apache.org/jira/browse/BEAM-4000
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
