[
https://issues.apache.org/jira/browse/BEAM-4000?focusedWorklogId=118502&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-118502
]
ASF GitHub Bot logged work on BEAM-4000:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jul/18 00:05
Start Date: 03/Jul/18 00:05
Worklog Time Spent: 10m
Work Description: charlesccychen commented on a change in pull request
#5715: [BEAM-4000] Futurize io subpackage
URL: https://github.com/apache/beam/pull/5715#discussion_r198317502
##########
File path: sdks/python/apache_beam/io/filesystem_test.py
##########
@@ -17,19 +17,28 @@
#
"""Unit tests for filesystem module."""
+from __future__ import absolute_import
+from __future__ import division
+
import bz2
import gzip
import logging
import os
import tempfile
import unittest
-from StringIO import StringIO
+from builtins import range
+from io import BytesIO
+
+from future import standard_library
+from future.utils import iteritems
from apache_beam.io.filesystem import CompressedFile
from apache_beam.io.filesystem import CompressionTypes
from apache_beam.io.filesystem import FileMetadata
from apache_beam.io.filesystem import FileSystem
+standard_library.install_aliases()
Review comment:
Should we do this before `import io`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 118502)
> Futurize and fix python 2 compatibility for io subpackage
> ---------------------------------------------------------
>
> Key: BEAM-4000
> URL: https://issues.apache.org/jira/browse/BEAM-4000
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
