[
https://issues.apache.org/jira/browse/BEAM-4006?focusedWorklogId=129945&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-129945
]
ASF GitHub Bot logged work on BEAM-4006:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Aug/18 20:59
Start Date: 01/Aug/18 20:59
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #5729:
[BEAM-4006] Futurize transforms subpackage
URL: https://github.com/apache/beam/pull/5729#discussion_r207028792
##########
File path: sdks/python/apache_beam/transforms/window.py
##########
@@ -246,10 +273,23 @@ def __init__(self, value, timestamp):
self.value = value
self.timestamp = Timestamp.of(timestamp)
- def __cmp__(self, other):
- if type(self) is not type(other):
- return cmp(type(self), type(other))
- return cmp((self.value, self.timestamp), (other.value, other.timestamp))
+ def __eq__(self, other):
+ return (type(self) == type(other)
+ and self.value == other.value
+ and self.timestamp == other.timestamp)
+
+ def __hash__(self):
+ return hash((type(self), self.value, self.timestamp))
+
+ def __ne__(self, other):
+ return not self == other
+
+ def __lt__(self, other):
Review comment:
Since types are not comparable in Python 3, how about we change the
implementation to:
```
def __lt__(self, other):
if type(self) != type(other):
return type(self).__name__ < type(other).__name__
if self.value != other.value:
return self.value < other.value
return self.timestamp < other.timestamp
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 129945)
Time Spent: 14h 10m (was: 14h)
> Futurize and fix python 2 compatibility for transforms subpackage
> -----------------------------------------------------------------
>
> Key: BEAM-4006
> URL: https://issues.apache.org/jira/browse/BEAM-4006
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 14h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
