[
https://issues.apache.org/jira/browse/BEAM-4006?focusedWorklogId=129099&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-129099
]
ASF GitHub Bot logged work on BEAM-4006:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jul/18 03:25
Start Date: 31/Jul/18 03:25
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #5729:
[BEAM-4006] Futurize transforms subpackage
URL: https://github.com/apache/beam/pull/5729#discussion_r206385144
##########
File path: sdks/python/apache_beam/transforms/window.py
##########
@@ -246,10 +263,33 @@ def __init__(self, value, timestamp):
self.value = value
self.timestamp = Timestamp.of(timestamp)
- def __cmp__(self, other):
- if type(self) is not type(other):
- return cmp(type(self), type(other))
- return cmp((self.value, self.timestamp), (other.value, other.timestamp))
+ def __eq__(self, other):
Review comment:
With this PR, the test becomes flaky, or in other words passes sometimes. It
may still flake if we implement all ops manually - did you try running it
multiple times?
I don't understand yet what change in behavior triggers this (we should find
out), but I think we need to fix the test regardless of this:
https://github.com/apache/beam/pull/6104.
Performance-wise, last week I used
https://github.com/apache/beam/compare/master...tvalentyn:transforms_microbenchmark
to compare different options, and did not notice a significant difference when
using @total_ordering (we could double check), so I favored the decorator to
reduce the boilerplate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 129099)
Time Spent: 13h 20m (was: 13h 10m)
> Futurize and fix python 2 compatibility for transforms subpackage
> -----------------------------------------------------------------
>
> Key: BEAM-4006
> URL: https://issues.apache.org/jira/browse/BEAM-4006
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 13h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
