[
https://issues.apache.org/jira/browse/BEAM-4006?focusedWorklogId=129944&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-129944
]
ASF GitHub Bot logged work on BEAM-4006:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Aug/18 20:59
Start Date: 01/Aug/18 20:59
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #5729:
[BEAM-4006] Futurize transforms subpackage
URL: https://github.com/apache/beam/pull/5729#discussion_r206991261
##########
File path: sdks/python/apache_beam/transforms/cy_combiners.py
##########
@@ -162,7 +167,7 @@ def extract_output(self):
self.sum %= 2**64
if self.sum >= INT64_MAX:
self.sum -= 2**64
- return self.sum / self.count if self.count else _NAN
+ return self.sum // self.count if self.count else _NAN
Review comment:
Please also make the change in line 266.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 129944)
Time Spent: 14h (was: 13h 50m)
> Futurize and fix python 2 compatibility for transforms subpackage
> -----------------------------------------------------------------
>
> Key: BEAM-4006
> URL: https://issues.apache.org/jira/browse/BEAM-4006
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 14h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
