[
https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=130553&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-130553
]
ASF GitHub Bot logged work on BEAM-4176:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Aug/18 18:16
Start Date: 02/Aug/18 18:16
Worklog Time Spent: 10m
Work Description: youngoli commented on a change in pull request #6073:
[BEAM-4176] Validate Runner Tests generalization and enable for local reference
runner
URL: https://github.com/apache/beam/pull/6073#discussion_r207325217
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1389,5 +1405,42 @@ artifactId=${project.name}
args argsNeeded
}
}
+
+
+ /**
***********************************************************************************************/
+
+ // Method to create the PortableValidatesRunnerTask.
+ project.ext.createPortableValidatesRunnerTask = {
Review comment:
Can it be made more clear that the parameter for this closure is supposed to
be a PortableValidatesRunnerConfiguration? While reading the code it took me a
while to figure out that this function does expect that class as a parameter.
If there's no downside to doing so, maybe use an explicit parameter like so:
```
project.ext.createPortableValidatesRunnerTask = {
PortableValidatesRunnerConfiguration it -> ... }
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 130553)
Time Spent: 9h 50m (was: 9h 40m)
> Java: Portable batch runner passes all ValidatesRunner tests that
> non-portable runner passes
> --------------------------------------------------------------------------------------------
>
> Key: BEAM-4176
> URL: https://issues.apache.org/jira/browse/BEAM-4176
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Ben Sidhom
> Priority: Major
> Time Spent: 9h 50m
> Remaining Estimate: 0h
>
> We need this as a sanity check that runner execution is correct.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
