[
https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=130552&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-130552
]
ASF GitHub Bot logged work on BEAM-4176:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Aug/18 18:16
Start Date: 02/Aug/18 18:16
Worklog Time Spent: 10m
Work Description: youngoli commented on a change in pull request #6073:
[BEAM-4176] Validate Runner Tests generalization and enable for local reference
runner
URL: https://github.com/apache/beam/pull/6073#discussion_r207321396
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -184,6 +186,20 @@ class BeamModulePlugin implements Plugin<Project> {
String tag = null // Sets the image tag (optional).
}
+ // A class defining the configuration for PortableValidatesRunner.
+ class PortableValidatesRunnerConfiguration {
Review comment:
I feel like it would be better to add the defaults for this configuration
object here instead of within the createPortableValidatesRunnerTask definition
for clarity to people who are modifying the gradle files. That way they can see
the defaults without having to read through the method, and it removes a bunch
of the ?: statements in the function definition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 130552)
Time Spent: 9h 40m (was: 9.5h)
> Java: Portable batch runner passes all ValidatesRunner tests that
> non-portable runner passes
> --------------------------------------------------------------------------------------------
>
> Key: BEAM-4176
> URL: https://issues.apache.org/jira/browse/BEAM-4176
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Ben Sidhom
> Priority: Major
> Time Spent: 9h 40m
> Remaining Estimate: 0h
>
> We need this as a sanity check that runner execution is correct.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
