[
https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=132044&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-132044
]
ASF GitHub Bot logged work on BEAM-4176:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Aug/18 20:04
Start Date: 07/Aug/18 20:04
Worklog Time Spent: 10m
Work Description: bsidhom commented on a change in pull request #6073:
[BEAM-4176] Validate Runner Tests generalization and enable for local reference
runner
URL: https://github.com/apache/beam/pull/6073#discussion_r208366752
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -193,6 +195,30 @@ class BeamModulePlugin implements Plugin<Project> {
String tag = null // Sets the image tag (optional).
}
+ // A class defining the configuration for PortableValidatesRunner.
+ class PortableValidatesRunnerConfiguration {
+ // Task name for validate runner case.
+ String name = 'validatesPortableRunner'
+ // Fully qualified JobServerClass name to use.
+ String jobServerDriver
+ // A string representing the jobServer Configuration.
+ String jobServerConfig
+ // Categories for tests to run.
+ Closure testCategories = {
+ includeCategories 'org.apache.beam.sdk.testing.ValidatesRunner'
+ excludeCategories
'org.apache.beam.sdk.testing.FlattenWithHeterogeneousCoders'
Review comment:
Should these default excludes apply to _all_ runners? If not, I think it
makes sense to put this on each runner to specify.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 132044)
Time Spent: 10.5h (was: 10h 20m)
> Java: Portable batch runner passes all ValidatesRunner tests that
> non-portable runner passes
> --------------------------------------------------------------------------------------------
>
> Key: BEAM-4176
> URL: https://issues.apache.org/jira/browse/BEAM-4176
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Ben Sidhom
> Priority: Major
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> We need this as a sanity check that runner execution is correct.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
