[
https://issues.apache.org/jira/browse/BEAM-5092?focusedWorklogId=131661&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-131661
]
ASF GitHub Bot logged work on BEAM-5092:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/18 23:24
Start Date: 06/Aug/18 23:24
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #6160:
[BEAM-5092] Make sure that SchemaCoder overrides consistentWithEquals.
URL: https://github.com/apache/beam/pull/6160#discussion_r208056593
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/JavaBeanSchema.java
##########
@@ -30,7 +30,9 @@
*
* <p>This provider finds (recursively) all public getters and setters in a
Java object, and creates
* schemas and rows that bind to those fields. The field order in the schema
is not guaranteed to
- * match the method order in the class.
+ * match the method order in the class. The Java object is expected to have
implemented a correct
+ * .equals() method. TODO: Validate equals() method is provided, and if not
generate a "slow" equals
+ * method based on * the schema.
Review comment:
Extra `*`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 131661)
Time Spent: 20m (was: 10m)
> Nexmark 10x performance regression
> ----------------------------------
>
> Key: BEAM-5092
> URL: https://issues.apache.org/jira/browse/BEAM-5092
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Andrew Pilloud
> Assignee: Reuven Lax
> Priority: Critical
> Time Spent: 20m
> Remaining Estimate: 0h
>
> There looks to be a 10x performance hit on the DirectRunner and Flink nexmark
> jobs. It first showed up in this build:
> [https://builds.apache.org/view/A-D/view/Beam/job/beam_PostCommit_Java_Nexmark_Direct/151/changes]
> [https://apache-beam-testing.appspot.com/explore?dashboard=5084698770407424]
> [https://apache-beam-testing.appspot.com/explore?dashboard=5699257587728384]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
