[
https://issues.apache.org/jira/browse/BEAM-5092?focusedWorklogId=131968&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-131968
]
ASF GitHub Bot logged work on BEAM-5092:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Aug/18 18:10
Start Date: 07/Aug/18 18:10
Worklog Time Spent: 10m
Work Description: timrobertson100 commented on a change in pull request
#6162: [BEAM-5092] Optimize Row comparison.
URL: https://github.com/apache/beam/pull/6162#discussion_r208331991
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/coders/RowCoder.java
##########
@@ -71,12 +71,17 @@
@Nullable private transient Coder<Row> delegateCoder = null;
public static RowCoder of(Schema schema) {
- return new RowCoder(schema, UUID.randomUUID());
+ UUID id = (schema.getUUID() == null) ? UUID.randomUUID() :
schema.getUUID();
+ return new RowCoder(schema, id);
}
private RowCoder(Schema schema, UUID id) {
if (schema.getUUID() != null) {
- checkArgument(schema.getUUID().equals(id));
+ checkArgument(
+ schema.getUUID().equals(id),
+ "Schema has a UUID that doesn't match argument to constructor. %s
v.s. $s",
Review comment:
"Preconditions only accepts the %s placeholder in error message strings"
2 minor typos (one fails build)
"Schema has a UUID that doesn't match argument to constructor. %s vs. %s",
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 131968)
Time Spent: 1h 50m (was: 1h 40m)
> Nexmark 10x performance regression
> ----------------------------------
>
> Key: BEAM-5092
> URL: https://issues.apache.org/jira/browse/BEAM-5092
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Andrew Pilloud
> Assignee: Reuven Lax
> Priority: Critical
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> There looks to be a 10x performance hit on the DirectRunner and Flink nexmark
> jobs. It first showed up in this build:
> [https://builds.apache.org/view/A-D/view/Beam/job/beam_PostCommit_Java_Nexmark_Direct/151/changes]
> [https://apache-beam-testing.appspot.com/explore?dashboard=5084698770407424]
> [https://apache-beam-testing.appspot.com/explore?dashboard=5699257587728384]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
