[
https://issues.apache.org/jira/browse/BEAM-5092?focusedWorklogId=131948&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-131948
]
ASF GitHub Bot logged work on BEAM-5092:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Aug/18 17:19
Start Date: 07/Aug/18 17:19
Worklog Time Spent: 10m
Work Description: reuvenlax commented on a change in pull request #6162:
[BEAM-5092] Optimize Row comparison.
URL: https://github.com/apache/beam/pull/6162#discussion_r208314699
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/coders/RowCoder.java
##########
@@ -72,6 +75,12 @@ public static RowCoder of(Schema schema) {
}
private RowCoder(Schema schema, UUID id) {
+ if (schema.getUUID() != null) {
+ checkArgument(schema.getUUID().equals(id));
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 131948)
Time Spent: 1h 40m (was: 1.5h)
> Nexmark 10x performance regression
> ----------------------------------
>
> Key: BEAM-5092
> URL: https://issues.apache.org/jira/browse/BEAM-5092
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Andrew Pilloud
> Assignee: Reuven Lax
> Priority: Critical
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> There looks to be a 10x performance hit on the DirectRunner and Flink nexmark
> jobs. It first showed up in this build:
> [https://builds.apache.org/view/A-D/view/Beam/job/beam_PostCommit_Java_Nexmark_Direct/151/changes]
> [https://apache-beam-testing.appspot.com/explore?dashboard=5084698770407424]
> [https://apache-beam-testing.appspot.com/explore?dashboard=5699257587728384]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
