[
https://issues.apache.org/jira/browse/BEAM-4374?focusedWorklogId=134672&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-134672
]
ASF GitHub Bot logged work on BEAM-4374:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Aug/18 19:56
Start Date: 14/Aug/18 19:56
Worklog Time Spent: 10m
Work Description: pabloem commented on a change in pull request #6205:
[BEAM-4374] Implementing a subset of the new metrics framework in python.
URL: https://github.com/apache/beam/pull/6205#discussion_r209771842
##########
File path: sdks/python/apache_beam/metrics/execution.py
##########
@@ -211,6 +215,31 @@ def to_runner_api(self):
for k, v in self.gauges.items()]
)
+ def to_runner_api_monitoring_infos(self, transform_id):
+ """Returns a list of MonitoringInfos for the metrics in this container."""
+ all_user_metrics = []
+ for k, v in self.counters.items():
+ all_user_metrics.append(int64_counter(
+ user_metric_urn(k.namespace, k.name),
Review comment:
If I understand correctly, the kind of aggregation is not part of the urn of
a counter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 134672)
Time Spent: 1.5h (was: 1h 20m)
> Update existing metrics in the FN API to use new Metric Schema
> --------------------------------------------------------------
>
> Key: BEAM-4374
> URL: https://issues.apache.org/jira/browse/BEAM-4374
> Project: Beam
> Issue Type: New Feature
> Components: beam-model
> Reporter: Alex Amato
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Update existing metrics to use the new proto and cataloging schema defined in:
> [_https://s.apache.org/beam-fn-api-metrics_]
> * Check in new protos
> * Define catalog file for metrics
> * Port existing metrics to use this new format, based on catalog
> names+metadata
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
