[
https://issues.apache.org/jira/browse/BEAM-4374?focusedWorklogId=134703&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-134703
]
ASF GitHub Bot logged work on BEAM-4374:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Aug/18 20:22
Start Date: 14/Aug/18 20:22
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #6205:
[BEAM-4374] Implementing a subset of the new metrics framework in python.
URL: https://github.com/apache/beam/pull/6205#discussion_r210090493
##########
File path: sdks/python/apache_beam/runners/worker/bundle_processor.py
##########
@@ -313,6 +313,14 @@ def metrics(self):
self._fix_output_tags(transform_id, op.progress_metrics())
for transform_id, op in self.ops.items()})
+ def monitoring_infos(self):
Review comment:
We don't have unit tests for bundle_processors. It will be a good idea to
start one and add test cases as and when we modify bundle_processor.
For now you can simply have dummy operator and directly access
bundle_processor.py fields to test it.
Actual op.monitoring_infos can be checked separately in the unit tests for
operators.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 134703)
Time Spent: 3h 10m (was: 3h)
> Update existing metrics in the FN API to use new Metric Schema
> --------------------------------------------------------------
>
> Key: BEAM-4374
> URL: https://issues.apache.org/jira/browse/BEAM-4374
> Project: Beam
> Issue Type: New Feature
> Components: beam-model
> Reporter: Alex Amato
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Update existing metrics to use the new proto and cataloging schema defined in:
> [_https://s.apache.org/beam-fn-api-metrics_]
> * Check in new protos
> * Define catalog file for metrics
> * Port existing metrics to use this new format, based on catalog
> names+metadata
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
