[
https://issues.apache.org/jira/browse/BEAM-4374?focusedWorklogId=134774&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-134774
]
ASF GitHub Bot logged work on BEAM-4374:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Aug/18 23:01
Start Date: 14/Aug/18 23:01
Worklog Time Spent: 10m
Work Description: ajamato commented on a change in pull request #6205:
[BEAM-4374] Implementing a subset of the new metrics framework in python.
URL: https://github.com/apache/beam/pull/6205#discussion_r210130540
##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner.py
##########
@@ -1304,17 +1351,25 @@ def query(self, filter=None):
class RunnerResult(runner.PipelineResult):
- def __init__(self, state, metrics_by_stage):
+ def __init__(self, state, metrics_by_stage, monitoring_infos_by_stage):
super(RunnerResult, self).__init__(state)
self._metrics_by_stage = metrics_by_stage
+ self._monitoring_infos_by_stage = monitoring_infos_by_stage
self._user_metrics = None
def wait_until_finish(self, duration=None):
return self._state
- def metrics(self):
+ def metrics(self, use_monitoring_infos=False, user_metrics_only=True):
Review comment:
Based on the few tests I have done, I have matched the existing
functionality. So we could go ahead and delete the old code if you would like.
I just thought of this as a precautionary thing to do before flipping it on.
I think its okay to rename to RunnerResult.monitoring_infos.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 134774)
Time Spent: 3.5h (was: 3h 20m)
> Update existing metrics in the FN API to use new Metric Schema
> --------------------------------------------------------------
>
> Key: BEAM-4374
> URL: https://issues.apache.org/jira/browse/BEAM-4374
> Project: Beam
> Issue Type: New Feature
> Components: beam-model
> Reporter: Alex Amato
> Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Update existing metrics to use the new proto and cataloging schema defined in:
> [_https://s.apache.org/beam-fn-api-metrics_]
> * Check in new protos
> * Define catalog file for metrics
> * Port existing metrics to use this new format, based on catalog
> names+metadata
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
