[ 
https://issues.apache.org/jira/browse/BEAM-5107?focusedWorklogId=136972&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-136972
 ]

ASF GitHub Bot logged work on BEAM-5107:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Aug/18 14:47
            Start Date: 22/Aug/18 14:47
    Worklog Time Spent: 10m 
      Work Description: echauchot commented on a change in pull request #6211: 
[BEAM-5107] Support ES-6.x for ElasticsearchIO
URL: https://github.com/apache/beam/pull/6211#discussion_r211969581
 
 

 ##########
 File path: 
sdks/java/io/elasticsearch-tests/elasticsearch-tests-common/src/test/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIOTestCommon.java
 ##########
 @@ -374,6 +433,8 @@ public String apply(JsonNode input) {
    * Tests that documents are dynamically routed to different types and not 
the type that is given
    * in the configuration. Documents should be routed to the a type of type_0 
or type_1 using a
    * modulo approach of the explicit id.
+   *
+   * <p>This test does not work with ES 6 because multiple type support within 
an index was removed.
    */
   void testWriteWithTypeFn() throws Exception {
 
 Review comment:
   rename testWriteWithTypeFn2x5x

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 136972)
    Time Spent: 7h  (was: 6h 40m)

> Support ES 6.x for ElasticsearchIO
> ----------------------------------
>
>                 Key: BEAM-5107
>                 URL: https://issues.apache.org/jira/browse/BEAM-5107
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-elasticsearch
>            Reporter: Dat Tran
>            Assignee: Etienne Chauchot
>            Priority: Major
>          Time Spent: 7h
>  Remaining Estimate: 0h
>
> Elasticsearch has released 6.3.2 but ElasticsearchIO only supports 2x-5.x.
> We should support ES 6.x for ElasticsearchIO.
> https://www.elastic.co/guide/en/elasticsearch/reference/current/index.html
> https://github.com/apache/beam/blob/master/sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to