[
https://issues.apache.org/jira/browse/BEAM-5107?focusedWorklogId=136975&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-136975
]
ASF GitHub Bot logged work on BEAM-5107:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Aug/18 14:47
Start Date: 22/Aug/18 14:47
Worklog Time Spent: 10m
Work Description: echauchot commented on a change in pull request #6211:
[BEAM-5107] Support ES-6.x for ElasticsearchIO
URL: https://github.com/apache/beam/pull/6211#discussion_r211891058
##########
File path:
sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java
##########
@@ -125,7 +125,8 @@
*
* <p>Optionally, you can provide {@link
ElasticsearchIO.Write.FieldValueExtractFn} using {@code
* withIndexFn()} or {@code withTypeFn()} to enable per-document routing to
the target Elasticsearch
- * index and type.
+ * index (all versions) and type (version <6). Support for type routing was
removed in Elasticsearch
+ * 6 (see
https://www.elastic.co/blog/index-type-parent-child-join-now-future-in-elasticsearch)
Review comment:
@dattran-vn01 In addition I don't see the type routing breaking change in
v6.x breaking changes list. Are you sure of that? I only see that in 6.0 new
created indexes can only contain one type. Please test type routing support and
if it is still supported in 6.x please remove the Jdoc comments and leave the
feature enabled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 136975)
Time Spent: 7h 20m (was: 7h 10m)
> Support ES 6.x for ElasticsearchIO
> ----------------------------------
>
> Key: BEAM-5107
> URL: https://issues.apache.org/jira/browse/BEAM-5107
> Project: Beam
> Issue Type: Improvement
> Components: io-java-elasticsearch
> Reporter: Dat Tran
> Assignee: Etienne Chauchot
> Priority: Major
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
> Elasticsearch has released 6.3.2 but ElasticsearchIO only supports 2x-5.x.
> We should support ES 6.x for ElasticsearchIO.
> https://www.elastic.co/guide/en/elasticsearch/reference/current/index.html
> https://github.com/apache/beam/blob/master/sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
