[
https://issues.apache.org/jira/browse/BEAM-5107?focusedWorklogId=136970&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-136970
]
ASF GitHub Bot logged work on BEAM-5107:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Aug/18 14:47
Start Date: 22/Aug/18 14:47
Worklog Time Spent: 10m
Work Description: echauchot commented on a change in pull request #6211:
[BEAM-5107] Support ES-6.x for ElasticsearchIO
URL: https://github.com/apache/beam/pull/6211#discussion_r211968823
##########
File path:
sdks/java/io/elasticsearch-tests/elasticsearch-tests-common/src/test/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIOTestCommon.java
##########
@@ -106,6 +110,62 @@ void testSizes() throws Exception {
assertThat("Wrong estimated size", estimatedSize,
greaterThan(AVERAGE_DOC_SIZE * numDocs));
}
+ void testSplit5x6x() throws Exception {
Review comment:
You need to re-architecture the tests:
1. ok to introduce testSplit5x6x in TestCommon because ES5 and ES6 split the
same and not ES2
2. ok to introduce an IT version of this test for the same reason
3. Change ESTestCommon.testSplit5x6x : it should be exactly the same as
previous ES5Test.testSplit modulo the final keywords you were right to add. And
UTests in ES5 and ES6 should just call
elasticsearchIOTestCommon.testSplit5x6x(); not create the index.
4. Change ESTestCommon.testITSplit5x6x: it should be exactly the same as
previous ES5Test.testSplitVolume module the final keywords you were right to
add.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 136970)
Time Spent: 6h 50m (was: 6h 40m)
> Support ES 6.x for ElasticsearchIO
> ----------------------------------
>
> Key: BEAM-5107
> URL: https://issues.apache.org/jira/browse/BEAM-5107
> Project: Beam
> Issue Type: Improvement
> Components: io-java-elasticsearch
> Reporter: Dat Tran
> Assignee: Etienne Chauchot
> Priority: Major
> Time Spent: 6h 50m
> Remaining Estimate: 0h
>
> Elasticsearch has released 6.3.2 but ElasticsearchIO only supports 2x-5.x.
> We should support ES 6.x for ElasticsearchIO.
> https://www.elastic.co/guide/en/elasticsearch/reference/current/index.html
> https://github.com/apache/beam/blob/master/sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
