[
https://issues.apache.org/jira/browse/BEAM-2930?focusedWorklogId=137866&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-137866
]
ASF GitHub Bot logged work on BEAM-2930:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Aug/18 15:57
Start Date: 24/Aug/18 15:57
Worklog Time Spent: 10m
Work Description: tweise commented on a change in pull request #6208:
[BEAM-2930] Side input support for Flink portable streaming.
URL: https://github.com/apache/beam/pull/6208#discussion_r212675555
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java
##########
@@ -108,27 +119,45 @@ public ExecutableStageDoFnOperator(
this.jobInfo = jobInfo;
this.contextFactory = contextFactory;
this.outputMap = outputMap;
+ this.sideInputIds = sideInputIds;
}
@Override
public void open() throws Exception {
super.open();
- ExecutableStage executableStage = ExecutableStage.fromPayload(payload);
+ executableStage = ExecutableStage.fromPayload(payload);
// TODO: Wire this into the distributed cache and make it pluggable.
// TODO: Do we really want this layer of indirection when accessing the
stage bundle factory?
// It's a little strange because this operator is responsible for the
lifetime of the stage
// bundle "factory" (manager?) but not the job or Flink bundle factories.
How do we make
// ownership of the higher level "factories" explicit? Do we care?
stageContext = contextFactory.get(jobInfo);
- // NOTE: It's safe to reuse the state handler between partitions because
each partition uses the
- // same backing runtime context and broadcast variables. We use checkState
below to catch errors
- // in backward-incompatible Flink changes.
- stateRequestHandler = stageContext.getStateRequestHandler(executableStage,
getRuntimeContext());
+
+ stateRequestHandler = getStateRequestHandler(executableStage);
stageBundleFactory = stageContext.getStageBundleFactory(executableStage);
progressHandler = BundleProgressHandler.unsupported();
}
+ private StateRequestHandler getStateRequestHandler(ExecutableStage
executableStage) {
+
+ if (!executableStage.getSideInputs().isEmpty()) {
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 137866)
Time Spent: 6h 40m (was: 6.5h)
> Flink support for portable side input
> -------------------------------------
>
> Key: BEAM-2930
> URL: https://issues.apache.org/jira/browse/BEAM-2930
> Project: Beam
> Issue Type: Sub-task
> Components: runner-flink
> Reporter: Henning Rohde
> Assignee: Thomas Weise
> Priority: Major
> Labels: portability
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
