[
https://issues.apache.org/jira/browse/BEAM-2930?focusedWorklogId=137863&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-137863
]
ASF GitHub Bot logged work on BEAM-2930:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Aug/18 15:57
Start Date: 24/Aug/18 15:57
Worklog Time Spent: 10m
Work Description: tweise commented on a change in pull request #6208:
[BEAM-2930] Side input support for Flink portable streaming.
URL: https://github.com/apache/beam/pull/6208#discussion_r212675392
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/SideInputHandler.java
##########
@@ -148,30 +147,45 @@ public void addSideInputValue(PCollectionView<?>
sideInput, WindowedValue<Iterab
@Nullable
@Override
public <T> T get(PCollectionView<T> view, BoundedWindow window) {
- @SuppressWarnings("unchecked")
- Coder<BoundedWindow> windowCoder =
- (Coder<BoundedWindow>)
view.getWindowingStrategyInternal().getWindowFn().windowCoder();
-
- StateTag<ValueState<Iterable<?>>> stateTag =
sideInputContentsTags.get(view);
-
- ValueState<Iterable<?>> state =
- stateInternals.state(StateNamespaces.window(windowCoder, window),
stateTag);
- // TODO: Add support for choosing which representation is contained based
upon the
- // side input materialization. We currently can assume that we always have
a multimap
- // materialization as that is the only supported type within the Java SDK.
- @Nullable Iterable<KV<?, ?>> elements = (Iterable<KV<?, ?>>) state.read();
+ @Nullable Iterable<?> elements = getIterable(view, window);
if (elements == null) {
elements = Collections.emptyList();
}
Review comment:
Not needed since side input isn't supposed to be accessed before the window
is ready. Added extra check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 137863)
Time Spent: 6h 20m (was: 6h 10m)
> Flink support for portable side input
> -------------------------------------
>
> Key: BEAM-2930
> URL: https://issues.apache.org/jira/browse/BEAM-2930
> Project: Beam
> Issue Type: Sub-task
> Components: runner-flink
> Reporter: Henning Rohde
> Assignee: Thomas Weise
> Priority: Major
> Labels: portability
> Time Spent: 6h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
