[
https://issues.apache.org/jira/browse/BEAM-5036?focusedWorklogId=145699&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-145699
]
ASF GitHub Bot logged work on BEAM-5036:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Sep/18 15:53
Start Date: 19/Sep/18 15:53
Worklog Time Spent: 10m
Work Description: iemejia commented on issue #6289: [BEAM-5036] Optimize
the FileBasedSink WriteOperation.moveToOutput()
URL: https://github.com/apache/beam/pull/6289#issuecomment-422856503
Interesting question, it is ideal to define and document a clear default
behavior for rename in all Beam filesystems (since there are no options allowed
in the API).
HDFS users probably will expect that the default rename behavior does NOT
overwrite (as HDFS works), and also because this implies possible data loss,
but I am not sure if there is a strong reason for other Filesystems to do
overwrite by default (e.g. Local).
cc @lukecwik too for eventual extra feedback since the original authors of
Beam FileSystems are not in the project anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 145699)
Time Spent: 2h 20m (was: 2h 10m)
> Optimize FileBasedSink's WriteOperation.moveToOutput()
> ------------------------------------------------------
>
> Key: BEAM-5036
> URL: https://issues.apache.org/jira/browse/BEAM-5036
> Project: Beam
> Issue Type: Improvement
> Components: io-java-files
> Affects Versions: 2.5.0
> Reporter: Jozef Vilcek
> Assignee: Tim Robertson
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> moveToOutput() methods in FileBasedSink.WriteOperation implements move by
> copy+delete. It would be better to use a rename() which can be much more
> effective for some filesystems.
> Filesystem must support cross-directory rename. BEAM-4861 is related to this
> for the case of HDFS filesystem.
> Feature was discussed here:
> http://mail-archives.apache.org/mod_mbox/beam-dev/201807.mbox/%3CCAF9t7_4Mp54pQ+vRrJrBh9Vx0=uaknupzd_qdh_qdm9vxll...@mail.gmail.com%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
