[ https://issues.apache.org/jira/browse/BEAM-5036?focusedWorklogId=146107&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-146107 ]
ASF GitHub Bot logged work on BEAM-5036: ---------------------------------------- Author: ASF GitHub Bot Created on: 20/Sep/18 19:46 Start Date: 20/Sep/18 19:46 Worklog Time Spent: 10m Work Description: timrobertson100 commented on issue #6289: [BEAM-5036] Optimize the FileBasedSink WriteOperation.moveToOutput() URL: https://github.com/apache/beam/pull/6289#issuecomment-423309448 Thanks everyone. @chamikaramj - if we are to correctly support an OVERWRITE_EXISTING_FILES flag I think we'd either have to pass the flag down into the filesystem implementations themselves, or do like the HDFS one does now and always throw FileAlreadyExistsException (note a user reports that issue today on user@ with AvroIO and LocalFileSystem) when the target is in place. The later would require some of them to do a "does target exist" check before attempting the move. Do you have a preference on that? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 146107) Time Spent: 3h (was: 2h 50m) > Optimize FileBasedSink's WriteOperation.moveToOutput() > ------------------------------------------------------ > > Key: BEAM-5036 > URL: https://issues.apache.org/jira/browse/BEAM-5036 > Project: Beam > Issue Type: Improvement > Components: io-java-files > Affects Versions: 2.5.0 > Reporter: Jozef Vilcek > Assignee: Tim Robertson > Priority: Major > Time Spent: 3h > Remaining Estimate: 0h > > moveToOutput() methods in FileBasedSink.WriteOperation implements move by > copy+delete. It would be better to use a rename() which can be much more > effective for some filesystems. > Filesystem must support cross-directory rename. BEAM-4861 is related to this > for the case of HDFS filesystem. > Feature was discussed here: > http://mail-archives.apache.org/mod_mbox/beam-dev/201807.mbox/%3CCAF9t7_4Mp54pQ+vRrJrBh9Vx0=uaknupzd_qdh_qdm9vxll...@mail.gmail.com%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)