[
https://issues.apache.org/jira/browse/BEAM-5036?focusedWorklogId=146797&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-146797
]
ASF GitHub Bot logged work on BEAM-5036:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Sep/18 16:42
Start Date: 22/Sep/18 16:42
Worklog Time Spent: 10m
Work Description: timrobertson100 edited a comment on issue #6289:
[BEAM-5036] Optimize the FileBasedSink WriteOperation.moveToOutput()
URL: https://github.com/apache/beam/pull/6289#issuecomment-423737137
@chamikaramj - thanks and I agree. This PR provides what folk have
outlined/requested, does not change the `FileSystem` API and I believe gets us
as close to allowing a `FileSystems.rename()` within a loop as is possible.
Some `FileSystem` implementations will currently always overwrite but we can
document that scenario or opt to open tickets to change to throw
`FileAlreadyExistsException` if we so wish.
I will provide tests for this unless someone has objection with the
implementation offered. I haven't yet seen anything specific but all comments
have helped in my understanding of the background (thank you!). If we want to
redesign things further we can discuss that on dev@.
@chamikaramj - would you be willing to be reviewer please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 146797)
Time Spent: 4h (was: 3h 50m)
> Optimize FileBasedSink's WriteOperation.moveToOutput()
> ------------------------------------------------------
>
> Key: BEAM-5036
> URL: https://issues.apache.org/jira/browse/BEAM-5036
> Project: Beam
> Issue Type: Improvement
> Components: io-java-files
> Affects Versions: 2.5.0
> Reporter: Jozef Vilcek
> Assignee: Tim Robertson
> Priority: Major
> Time Spent: 4h
> Remaining Estimate: 0h
>
> moveToOutput() methods in FileBasedSink.WriteOperation implements move by
> copy+delete. It would be better to use a rename() which can be much more
> effective for some filesystems.
> Filesystem must support cross-directory rename. BEAM-4861 is related to this
> for the case of HDFS filesystem.
> Feature was discussed here:
> http://mail-archives.apache.org/mod_mbox/beam-dev/201807.mbox/%3CCAF9t7_4Mp54pQ+vRrJrBh9Vx0=uaknupzd_qdh_qdm9vxll...@mail.gmail.com%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
