[
https://issues.apache.org/jira/browse/BEAM-5607?focusedWorklogId=150460&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-150460
]
ASF GitHub Bot logged work on BEAM-5607:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Oct/18 17:12
Start Date: 02/Oct/18 17:12
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #6543:
[BEAM-5607] Set python_version of typing library < 3.7.0
URL: https://github.com/apache/beam/pull/6543#discussion_r222036587
##########
File path: sdks/python/setup.py
##########
@@ -124,7 +124,7 @@ def get_version():
'pytz>=2018.3,<=2018.4',
'pyyaml>=3.12,<4.0.0',
'pyvcf>=0.6.8,<0.7.0',
- 'typing>=3.6.0,<3.7.0',
+ 'typing>=3.6.0,<3.7.0; python_version < "3.7.0"',
Review comment:
I was not aware of this usage. If this works, we can probably consolidate
our REQUIRED_PACKAGES_PY3_ONLY etc parts here as well.
(Similarly we can use a single requirements base file for 2 different Docker
files for py2 and py3)
@tvalentyn
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 150460)
Time Spent: 20m (was: 10m)
> Typing library no longer provisional in Python 3.7
> --------------------------------------------------
>
> Key: BEAM-5607
> URL: https://issues.apache.org/jira/browse/BEAM-5607
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Manu Zhang
> Assignee: Manu Zhang
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This is an issue coming from future since the target version in the [initial
> proposal|https://lists.apache.org/thread.html/5371469de567357b1431606f766217ef73a9098dc45046f51a6ecceb@%3Cdev.beam.apache.org%3E]
> is up to 3.6. Running python tests in 3.7 would throw the following error
> because the [typing library is no longer provisional in Python
> 3.7|https://github.com/python/typing#important-dates]
> {code}
> sdks/python/.eggs/typing-3.6.6-py3.7.egg/typing.py", line 1004, in __new__
> self._abc_registry = extra._abc_registry
> AttributeError: type object 'Callable' has no attribute '_abc_registry'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
