[
https://issues.apache.org/jira/browse/BEAM-5607?focusedWorklogId=151279&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-151279
]
ASF GitHub Bot logged work on BEAM-5607:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Oct/18 16:55
Start Date: 04/Oct/18 16:55
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #6543:
[BEAM-5607] Set python_version of typing library < 3.7.0
URL: https://github.com/apache/beam/pull/6543#discussion_r222748910
##########
File path: sdks/python/setup.py
##########
@@ -124,7 +124,7 @@ def get_version():
'pytz>=2018.3,<=2018.4',
'pyyaml>=3.12,<4.0.0',
'pyvcf>=0.6.8,<0.7.0',
- 'typing>=3.6.0,<3.7.0',
+ 'typing>=3.6.0,<3.7.0; python_version < "3.7.0"',
Review comment:
Thanks, @manuzhang , I'll come back to BEAM-5607. It's definitely worthwhile
to also add tox suites for all 3.4 - 3.7. Hopefully in a way we can run the
suites for different versions in parallel. Feel free to add a feature request
as subtask for BEAM-1251 to add test coverage.
Given `typing` description on PyPi, should we set `python_version < "3.5.0"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 151279)
Time Spent: 1h (was: 50m)
> Typing library no longer provisional in Python 3.7
> --------------------------------------------------
>
> Key: BEAM-5607
> URL: https://issues.apache.org/jira/browse/BEAM-5607
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Manu Zhang
> Assignee: Manu Zhang
> Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> This is an issue coming from future since the target version in the [initial
> proposal|https://lists.apache.org/thread.html/5371469de567357b1431606f766217ef73a9098dc45046f51a6ecceb@%3Cdev.beam.apache.org%3E]
> is up to 3.6. Running python tests in 3.7 would throw the following error
> because the [typing library is no longer provisional in Python
> 3.7|https://github.com/python/typing#important-dates]
> {code}
> sdks/python/.eggs/typing-3.6.6-py3.7.egg/typing.py", line 1004, in __new__
> self._abc_registry = extra._abc_registry
> AttributeError: type object 'Callable' has no attribute '_abc_registry'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
