[
https://issues.apache.org/jira/browse/BEAM-5607?focusedWorklogId=151811&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-151811
]
ASF GitHub Bot logged work on BEAM-5607:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Oct/18 19:28
Start Date: 05/Oct/18 19:28
Worklog Time Spent: 10m
Work Description: tvalentyn commented on issue #6543: [BEAM-5607] Set
python_version of typing library < 3.5.0
URL: https://github.com/apache/beam/pull/6543#issuecomment-427474422
LGTM
Thanks, @manuzhang.
Note that you can give reviewers a heads-up that next iteration is ready for
review with "PTAL" or a similar comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 151811)
Time Spent: 1h 10m (was: 1h)
> Typing library no longer provisional in Python 3.7
> --------------------------------------------------
>
> Key: BEAM-5607
> URL: https://issues.apache.org/jira/browse/BEAM-5607
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Manu Zhang
> Assignee: Manu Zhang
> Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> This is an issue coming from future since the target version in the [initial
> proposal|https://lists.apache.org/thread.html/5371469de567357b1431606f766217ef73a9098dc45046f51a6ecceb@%3Cdev.beam.apache.org%3E]
> is up to 3.6. Running python tests in 3.7 would throw the following error
> because the [typing library is no longer provisional in Python
> 3.7|https://github.com/python/typing#important-dates]
> {code}
> sdks/python/.eggs/typing-3.6.6-py3.7.egg/typing.py", line 1004, in __new__
> self._abc_registry = extra._abc_registry
> AttributeError: type object 'Callable' has no attribute '_abc_registry'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
