[
https://issues.apache.org/jira/browse/BEAM-5315?focusedWorklogId=152324&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-152324
]
ASF GitHub Bot logged work on BEAM-5315:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Oct/18 17:41
Start Date: 08/Oct/18 17:41
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #6590:
[BEAM-5315] Partially port io
URL: https://github.com/apache/beam/pull/6590#discussion_r223443461
##########
File path: sdks/python/apache_beam/io/source_test_utils_test.py
##########
@@ -47,12 +48,18 @@ def _create_source(self, data):
for bundle in source.split(float('inf')):
return bundle.source
+ @unittest.skipIf(os.environ.get('RUN_SKIPPED_PY3_TESTS') != '1',
+ 'This test still needs to be fixed on Python 3'
+ 'TODO: BEAM-5627')
Review comment:
> Using the new env var I was able to verify this, and this is in fact a
highly recurring error. Only this particular error has the Jira code.
My point is that when we write `#TODO: BEAM-1234` we mean that we expect
that the failure will be fixed (or partially fixed) once BEAM-1234 is resolved.
So if the test is failing for a different reason than is captured by BEAM-1234,
then we should either use a generic Jira "Finish Python 3 porting for module
xxx" or file a new Jira - if you think that underlying problem is worth
tracking as an issue of its own and/or can be worked on in parallel. That said,
are the Jira's you link in this PR accurate?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 152324)
Time Spent: 2h 50m (was: 2h 40m)
> Finish Python 3 porting for io module
> -------------------------------------
>
> Key: BEAM-5315
> URL: https://issues.apache.org/jira/browse/BEAM-5315
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Simon
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
