[
https://issues.apache.org/jira/browse/BEAM-5315?focusedWorklogId=152140&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-152140
]
ASF GitHub Bot logged work on BEAM-5315:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Oct/18 05:37
Start Date: 08/Oct/18 05:37
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #6590:
[BEAM-5315] Partially port io
URL: https://github.com/apache/beam/pull/6590#discussion_r223249310
##########
File path: sdks/python/apache_beam/io/filebasedsource_test.py
##########
@@ -51,6 +52,9 @@
class LineSource(FileBasedSource):
+ @unittest.skipIf(sys.version_info[0] == 3, 'This test still needs to be '
Review comment:
Let's introduce an environment variable `RUN_SKIPPED_PY3_TESTS`, and if it
is set to 1, let's not skip the tests. In a separate PR we should also add a
possibility to unskip Python 3 tests we have already skipped. This will make it
easier to see how many tests we should still fix, and which tests are already
passing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 152140)
Time Spent: 1h 50m (was: 1h 40m)
> Finish Python 3 porting for io module
> -------------------------------------
>
> Key: BEAM-5315
> URL: https://issues.apache.org/jira/browse/BEAM-5315
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Simon
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
