[
https://issues.apache.org/jira/browse/BEAM-5315?focusedWorklogId=152138&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-152138
]
ASF GitHub Bot logged work on BEAM-5315:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Oct/18 05:37
Start Date: 08/Oct/18 05:37
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #6590:
[BEAM-5315] Partially port io
URL: https://github.com/apache/beam/pull/6590#discussion_r223250514
##########
File path: sdks/python/setup.py
##########
@@ -140,7 +140,7 @@ def get_version():
# oauth2client >=4 only works with google-apitools>=0.5.18.
'google-apitools>=0.5.18,<=0.5.20',
'proto-google-cloud-datastore-v1>=0.90.0,<=0.90.4',
- 'googledatastore==7.0.1',
+ 'googledatastore==7.0.1; python_version < "3.5.0"',
Review comment:
Let's change version qualifier to `python_version < "3.0"`, since AFAIK
googledatastore will not work on any version of Python 3. We can also add a
`#TODO(BEAM-...)` comment, in case anyone reading this line will wonder.
Note that we used `python_version < "3.5.0"` on `typing` is a back-port
module required only for Python interpreter less that 3.5.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 152138)
Time Spent: 1h 40m (was: 1.5h)
> Finish Python 3 porting for io module
> -------------------------------------
>
> Key: BEAM-5315
> URL: https://issues.apache.org/jira/browse/BEAM-5315
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Simon
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
