[
https://issues.apache.org/jira/browse/BEAM-4130?focusedWorklogId=152377&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-152377
]
ASF GitHub Bot logged work on BEAM-4130:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Oct/18 19:49
Start Date: 08/Oct/18 19:49
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #6607:
[BEAM-4130] Use port 0 to pick dynamic port-BugFix
URL: https://github.com/apache/beam/pull/6607#discussion_r223478440
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkJobServerDriver.java
##########
@@ -201,7 +201,7 @@ public void stop() {
private GrpcFnServer<InMemoryJobService> createJobServer() throws
IOException {
InMemoryJobService service = createJobService();
GrpcFnServer<InMemoryJobService> jobServiceGrpcFnServer;
- if (Strings.isNullOrEmpty(configuration.host)) {
+ if (configuration.port == 0) {
Review comment:
This makes the behavior less consistent.
Example scenarios:
When host=null : JobPort Dynamic, ArtifactPort Dynamic
When host=localhost: JobPort 8099, ArtifactPort 8098
When host=localhost, jobPort=0: JobPort dynamic, ArtifactPort 8098
....
Just checking if the JobPort is 0 will remove this confusion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 152377)
Time Spent: 10h 40m (was: 10.5h)
> Portable Flink runner JobService entry point in a Docker container
> ------------------------------------------------------------------
>
> Key: BEAM-4130
> URL: https://issues.apache.org/jira/browse/BEAM-4130
> Project: Beam
> Issue Type: New Feature
> Components: runner-flink
> Reporter: Ben Sidhom
> Assignee: Maximilian Michels
> Priority: Minor
> Fix For: 2.7.0
>
> Time Spent: 10h 40m
> Remaining Estimate: 0h
>
> The portable Flink runner exists as a Job Service that runs somewhere. We
> need a main entry point that itself spins up the job service (and artifact
> staging service). The main program itself should be packaged into an uberjar
> such that it can be run locally or submitted to a Flink deployment via `flink
> run`.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
