[
https://issues.apache.org/jira/browse/BEAM-4130?focusedWorklogId=152635&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-152635
]
ASF GitHub Bot logged work on BEAM-4130:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Oct/18 11:37
Start Date: 09/Oct/18 11:37
Worklog Time Spent: 10m
Work Description: mxm closed pull request #6607: [BEAM-4130] Use port 0
to pick dynamic port-BugFix
URL: https://github.com/apache/beam/pull/6607
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkJobServerDriver.java
b/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkJobServerDriver.java
index 2096cb98550..34f2edb5abb 100644
---
a/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkJobServerDriver.java
+++
b/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkJobServerDriver.java
@@ -17,7 +17,6 @@
*/
package org.apache.beam.runners.flink;
-import com.google.common.base.Strings;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.common.util.concurrent.MoreExecutors;
import com.google.common.util.concurrent.ThreadFactoryBuilder;
@@ -201,7 +200,7 @@ public void stop() {
private GrpcFnServer<InMemoryJobService> createJobServer() throws
IOException {
InMemoryJobService service = createJobService();
GrpcFnServer<InMemoryJobService> jobServiceGrpcFnServer;
- if (Strings.isNullOrEmpty(configuration.host)) {
+ if (configuration.port == 0) {
jobServiceGrpcFnServer = GrpcFnServer.allocatePortAndCreateFor(service,
jobServerFactory);
} else {
Endpoints.ApiServiceDescriptor descriptor =
@@ -239,7 +238,7 @@ private InMemoryJobService createJobService() throws
IOException {
throws IOException {
BeamFileSystemArtifactStagingService service = new
BeamFileSystemArtifactStagingService();
final GrpcFnServer<BeamFileSystemArtifactStagingService>
artifactStagingService;
- if (Strings.isNullOrEmpty(configuration.host)) {
+ if (configuration.artifactPort == 0) {
artifactStagingService =
GrpcFnServer.allocatePortAndCreateFor(service,
artifactServerFactory);
} else {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 152635)
Time Spent: 11.5h (was: 11h 20m)
> Portable Flink runner JobService entry point in a Docker container
> ------------------------------------------------------------------
>
> Key: BEAM-4130
> URL: https://issues.apache.org/jira/browse/BEAM-4130
> Project: Beam
> Issue Type: New Feature
> Components: runner-flink
> Reporter: Ben Sidhom
> Assignee: Maximilian Michels
> Priority: Minor
> Fix For: 2.7.0
>
> Time Spent: 11.5h
> Remaining Estimate: 0h
>
> The portable Flink runner exists as a Job Service that runs somewhere. We
> need a main entry point that itself spins up the job service (and artifact
> staging service). The main program itself should be packaged into an uberjar
> such that it can be run locally or submitted to a Flink deployment via `flink
> run`.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
