[
https://issues.apache.org/jira/browse/BEAM-4130?focusedWorklogId=152390&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-152390
]
ASF GitHub Bot logged work on BEAM-4130:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Oct/18 20:29
Start Date: 08/Oct/18 20:29
Worklog Time Spent: 10m
Work Description: mxm commented on a change in pull request #6607:
[BEAM-4130] Use port 0 to pick dynamic port-BugFix
URL: https://github.com/apache/beam/pull/6607#discussion_r223488123
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkJobServerDriver.java
##########
@@ -201,7 +201,7 @@ public void stop() {
private GrpcFnServer<InMemoryJobService> createJobServer() throws
IOException {
InMemoryJobService service = createJobService();
GrpcFnServer<InMemoryJobService> jobServiceGrpcFnServer;
- if (Strings.isNullOrEmpty(configuration.host)) {
+ if (configuration.port == 0) {
Review comment:
Yes, that is better. Do you think we could also respect the host name when
the port is 0? As of now, it would get ignored.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 152390)
Time Spent: 11h (was: 10h 50m)
> Portable Flink runner JobService entry point in a Docker container
> ------------------------------------------------------------------
>
> Key: BEAM-4130
> URL: https://issues.apache.org/jira/browse/BEAM-4130
> Project: Beam
> Issue Type: New Feature
> Components: runner-flink
> Reporter: Ben Sidhom
> Assignee: Maximilian Michels
> Priority: Minor
> Fix For: 2.7.0
>
> Time Spent: 11h
> Remaining Estimate: 0h
>
> The portable Flink runner exists as a Job Service that runs somewhere. We
> need a main entry point that itself spins up the job service (and artifact
> staging service). The main program itself should be packaged into an uberjar
> such that it can be run locally or submitted to a Flink deployment via `flink
> run`.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
