[
https://issues.apache.org/jira/browse/BEAM-4374?focusedWorklogId=153788&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-153788
]
ASF GitHub Bot logged work on BEAM-4374:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Oct/18 07:21
Start Date: 12/Oct/18 07:21
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #6205:
[BEAM-4374] Implementing a subset of the new metrics framework in python.
URL: https://github.com/apache/beam/pull/6205#discussion_r224691794
##########
File path: model/fn-execution/src/main/proto/beam_fn_api.proto
##########
@@ -302,6 +308,45 @@ message MonitoringInfo {
// Some systems such as Stackdriver will be able to aggregate the metrics
// using a subset of the provided labels
map<string, string> labels = 5;
+
+ // The walltime of the most recent update.
+ // Useful for aggregation for Latest types such as LatestInt64.
+ google.protobuf.Timestamp timestamp = 6;
+}
+
+message MonitoringInfoUrns {
+ enum Enum {
Review comment:
I wonder if we should consider using the yaml file as the source of truth,
rather than having redundancy here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 153788)
Time Spent: 7.5h (was: 7h 20m)
> Update existing metrics in the FN API to use new Metric Schema
> --------------------------------------------------------------
>
> Key: BEAM-4374
> URL: https://issues.apache.org/jira/browse/BEAM-4374
> Project: Beam
> Issue Type: New Feature
> Components: beam-model
> Reporter: Alex Amato
> Priority: Major
> Time Spent: 7.5h
> Remaining Estimate: 0h
>
> Update existing metrics to use the new proto and cataloging schema defined in:
> [_https://s.apache.org/beam-fn-api-metrics_]
> * Check in new protos
> * Define catalog file for metrics
> * Port existing metrics to use this new format, based on catalog
> names+metadata
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
