[
https://issues.apache.org/jira/browse/BEAM-4374?focusedWorklogId=153797&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-153797
]
ASF GitHub Bot logged work on BEAM-4374:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Oct/18 07:29
Start Date: 12/Oct/18 07:29
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #6205:
[BEAM-4374] Implementing a subset of the new metrics framework in python.
URL: https://github.com/apache/beam/pull/6205#discussion_r224693651
##########
File path: sdks/python/apache_beam/runners/worker/bundle_processor.py
##########
@@ -313,6 +313,14 @@ def metrics(self):
self._fix_output_tags(transform_id, op.progress_metrics())
for transform_id, op in self.ops.items()})
+ def monitoring_infos(self):
Review comment:
Testing the bundle processor requires providing a properly formed execution
tree. The easiest way by far to construct such a tree is by using the
user-facing API (which, for the moment, is also significantly more stable).
This is also in line with the mantra of testing user-facing behavior rather
than implementation details.
Of course sometimes one needs more focused implementation detail tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 153797)
Time Spent: 7h 40m (was: 7.5h)
> Update existing metrics in the FN API to use new Metric Schema
> --------------------------------------------------------------
>
> Key: BEAM-4374
> URL: https://issues.apache.org/jira/browse/BEAM-4374
> Project: Beam
> Issue Type: New Feature
> Components: beam-model
> Reporter: Alex Amato
> Priority: Major
> Time Spent: 7h 40m
> Remaining Estimate: 0h
>
> Update existing metrics to use the new proto and cataloging schema defined in:
> [_https://s.apache.org/beam-fn-api-metrics_]
> * Check in new protos
> * Define catalog file for metrics
> * Port existing metrics to use this new format, based on catalog
> names+metadata
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
