[
https://issues.apache.org/jira/browse/BEAM-4374?focusedWorklogId=153803&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-153803
]
ASF GitHub Bot logged work on BEAM-4374:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Oct/18 07:40
Start Date: 12/Oct/18 07:40
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #6205:
[BEAM-4374] Implementing a subset of the new metrics framework in python.
URL: https://github.com/apache/beam/pull/6205#discussion_r224693651
##########
File path: sdks/python/apache_beam/runners/worker/bundle_processor.py
##########
@@ -313,6 +313,14 @@ def metrics(self):
self._fix_output_tags(transform_id, op.progress_metrics())
for transform_id, op in self.ops.items()})
+ def monitoring_infos(self):
Review comment:
Testing the bundle processor requires providing a properly formed execution
tree. The easiest way *by far* to correctly construct such a tree is by using
the user-facing API (which, for the moment, is also significantly more stable).
Though some simplification can be done (especially once the legacy worker goes
away), the inherent inter-dependencies here will mean that this will remain
true. This is also in line with the mantra of testing user-facing behavior
rather than implementation details.
Of course sometimes one needs more focused implementation detail tests. But
often tests that depend heavily on mocks of complicated systems tend to be
brittle, require constant updates, often lack coverage, and even get out of
sync with real-world use.
Put another way, the fn_api_runner_tests are not true end-to-end tests; the
fn_api_runner was originally written to be a testing fake to aid the
development of the fn_api worker (and frontend). The fact that we're now using
it as a direct runner is just because it's so much faster and allows us to
share more code with real portable runners.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 153803)
Time Spent: 7h 50m (was: 7h 40m)
> Update existing metrics in the FN API to use new Metric Schema
> --------------------------------------------------------------
>
> Key: BEAM-4374
> URL: https://issues.apache.org/jira/browse/BEAM-4374
> Project: Beam
> Issue Type: New Feature
> Components: beam-model
> Reporter: Alex Amato
> Priority: Major
> Time Spent: 7h 50m
> Remaining Estimate: 0h
>
> Update existing metrics to use the new proto and cataloging schema defined in:
> [_https://s.apache.org/beam-fn-api-metrics_]
> * Check in new protos
> * Define catalog file for metrics
> * Port existing metrics to use this new format, based on catalog
> names+metadata
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
