kanterov commented on a change in pull request #11034: [BEAM-9424] Allow
grouping by LogicalType
URL: https://github.com/apache/beam/pull/11034#discussion_r387349711
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/coders/RowCoderGenerator.java
##########
@@ -401,6 +404,20 @@ private static StackManipulation
getCoder(Schema.FieldType fieldType) {
}
}
+ private static StackManipulation logicalTypeCoder(
+ Schema.LogicalType logicalType, StackManipulation baseCoder) {
+ throw new UnsupportedOperationException("not implemented");
Review comment:
This section is left unimplemented, and that's why the test is failing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services