reuvenlax commented on issue #11034: [BEAM-9424] Allow grouping by LogicalType URL: https://github.com/apache/beam/pull/11034#issuecomment-595322444 @kanterov this is because (as I mentioned before) Row.getValue today always returns the base type (in this case int), because that's how we store it. This has the side effect of passing the base value into your combiner, which is currently expecting the value type. This inconsistency keeps causing strange effects like this. I think we need getValue to return the same types passed into addValues (the value type). I'm trying to think of a good way to do this without breaking other semantics and impacting performance.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
